Add support for canceling resumable uploads #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawmra
commented
Nov 16, 2024
Comment on lines
+633
to
+635
| func (s *Server) deleteResumableUpload(r *http.Request) jsonResponse { | ||
| return jsonResponse{status: 499} | ||
| } |
There was a problem hiding this comment.
Ideally, if a non-existent session URI is specified, the server should return a 404, and a PUT request for a deleted session URI should respond with 499. However, since the upload process did not seem to specifically check whether the session URI actually exists, I decided to follow that approach and not pursue this level of reality.
fsouza
approved these changes
Jan 3, 2025
Comment on lines
+633
to
+635
| func (s *Server) deleteResumableUpload(r *http.Request) jsonResponse { | ||
| return jsonResponse{status: 499} | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1767
This PR adds support for canceling resumable uploads.
The implementation is based on the guides and observed behavior, as this functionality was not explicitly documented in the API references.
I'm new to Go, so please feel free to let me know if you have any concerns about naming conventions, code organization, or anything else.
Thanks for maintaining this great project!